fix(bpp): transition from IDLE to WAITING APPROVAL #6051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulfaqar-azmi-t4
requested review from
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
TomohitoAndo,
tkimura4,
rej55,
danielsanchezaran,
soblin,
maxime-clem,
TakaHoribe and
takayuki5168
as code owners
github-actions
bot
added
the
component:planning
7 tasks
satoshi-ota
approved these changes
Jan 11, 2024
rej55
reviewed
Jan 11, 2024
...ath_planner_common/include/behavior_path_planner_common/interface/scene_module_interface.hpp
Outdated
Show resolved
Hide resolved
zulfaqar-azmi-t4
force-pushed
the
fix-scene-module-interface-state-transition
branch
2 times, most recently
from
834e055
to
767b0a0
Compare
zulfaqar-azmi-t4
force-pushed
the
fix-scene-module-interface-state-transition
branch
from
767b0a0
to
e4d2748
Compare
zulfaqar-azmi-t4
force-pushed
the
fix-scene-module-interface-state-transition
branch
from
e4d2748
to
e98ac1c
Compare
kyoichi-sugahara
approved these changes
Jan 31, 2024
zulfaqar-azmi-t4
added
the
tag:run-build-and-test-differential
rej55
reviewed
Jan 31, 2024
...ath_planner_common/include/behavior_path_planner_common/interface/scene_module_interface.hpp
Outdated
Show resolved
Hide resolved
tkimura4
approved these changes
Jan 31, 2024
rej55
approved these changes
Jan 31, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6051 +/- ##
=======================================
Coverage 14.38% 14.38%
=======================================
Files 1907 1907
Lines 129935 129922 -13
Branches 37616 37613 -3
=======================================
Hits 18695 18695
+ Misses 90230 90217 -13
Partials 21010 21010
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…anner_common/interface/scene_module_interface.hpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
force-pushed
the
fix-scene-module-interface-state-transition
branch
from
0c72939
to
12b65d8
Compare
|
I updated this branch to import #6278. |
|
Thank you so much @HansRobo!! |
zulfaqar-azmi-t4
deleted the
fix-scene-module-interface-state-transition
branch
anhnv3991
pushed a commit
to anhnv3991/autoware.universe
that referenced
this pull request
Feb 13, 2024
…n#6051) * fix(bpp): explicitly set the initial state Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * remove isWaitingApproval() from state transition Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Update planning/behavior_path_planner_common/include/behavior_path_planner_common/interface/scene_module_interface.hpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> * explicitly set the initial state Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * remove setInitState in start_planner_module Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…n#6051) * fix(bpp): explicitly set the initial state Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * remove isWaitingApproval() from state transition Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Update planning/behavior_path_planner_common/include/behavior_path_planner_common/interface/scene_module_interface.hpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> * explicitly set the initial state Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * remove setInitState in start_planner_module Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
satoshi-ota
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 6, 2024
…n#6051) * fix(bpp): explicitly set the initial state Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * remove isWaitingApproval() from state transition Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Update planning/behavior_path_planner_common/include/behavior_path_planner_common/interface/scene_module_interface.hpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> * explicitly set the initial state Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * remove setInitState in start_planner_module Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current state transition skips WAITING_APPROVAL and jumps from IDLE to RUNNING.
This cause some minor issue during refactoring lane change.
Since transitioning to WAITING_APPROVAL is needed, and most of the modules doesn't use the function, this PR renamed the
canTransitionIdleToRunningStatetocanTransitionIdleToWaitingApprovalState.Tests performed
Evaluator result TIER IV internal link
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.